Skip to content

Conversation

@hudaif747
Copy link
Collaborator

@hudaif747 hudaif747 commented May 20, 2025

Description

Replace default export icon button with print icon to improve visibility

Related Issues

#405

Design Decisions

The export button in the line chart has been updated to a more recognizable print icon to improve user visibility. This was done by modifying the associated CSS class and embedding the SVG icon directly as content (This is the recommended way according to the github issues thread)

Performance & Quality

Checklist

I, the author of this PR checked the following requirements for good software quality:

  • The code is properly formatted (I ran the formatter)
  • The code is written with our software quality standards (I ran the linter)
  • The code is written using our code style
  • Extensive in source documentation has been added
  • Unit and/or integration tests have been added
  • All texts have been internationalized with at least the following languages:
    • English
    • German
  • I tried addressing all new accessibility problems displayed in the console and documented if they can't be fixed
  • I attached performance measurements to prevent performance degradation
  • I added the changes to the next release section of the changelog

I, the reviewer checked the following things:

  • I ran the software once and tried all new and related functionality to this PR
  • I looked at all new and changed lines of code and commented on possible problems
  • I read the added documentation and checked if it is understandable and clear
  • I checked the added tests for completeness
  • I checked the internationalized strings for spelling errors
  • I checked the performance metrics for problems or unexplained degradation
  • I checked that the changes are noted in the changelog

@hudaif747 hudaif747 self-assigned this May 20, 2025
JonasGilg
JonasGilg previously approved these changes May 26, 2025
@JonasGilg
Copy link
Collaborator

Thanks, looks good!

Base automatically changed from feature/migrate-to-new-backend to develop May 28, 2025 12:51
@JonasGilg JonasGilg dismissed their stale review May 28, 2025 12:51

The base branch was changed.

@hudaif747 hudaif747 force-pushed the feature/export-icon-change branch from 3425238 to 08cc160 Compare August 11, 2025 12:02
@github-actions
Copy link

Test Results

133 tests  ±0   133 ✅ ±0   36s ⏱️ -1s
 40 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 08cc160. ± Comparison against base commit a0c4d2b.

@hudaif747 hudaif747 requested a review from JonasGilg August 11, 2025 12:08
@NXXR
Copy link
Collaborator

NXXR commented Sep 9, 2025

@NXXR feedback to Sarah when added (User Feedback 11)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants