[준석] 8장 정리 #34
Open
[준석] 8장 정리 #34
+256
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juy4556
requested review from
headF1rst,
rilac1 and
waterfogSW
as code owners
Collaborator
|
|
waterfogSW
approved these changes
Nov 13, 2022
8장 - 의존성 관리하기/이준석.md
Outdated
Comment on lines
+252
to
+256
Member
There was a problem hiding this comment.
맞아요 저도 교수님 패턴 적용이 이상하다 생각했습니다 👍🏼
rilac1
reviewed
Nov 16, 2022
8장 - 의존성 관리하기/이준석.md
Outdated
Collaborator
There was a problem hiding this comment.
음료와 Size를 상속관계로 구현하는 것 대신 위에서 언급한 생성자 방식이나 setter 방식을 통해 Size를 넣어주는 것이 좋아보이네요!
"상속보다는 합성을 사용하라" 라는 원칙을 적용하기 좋은 사례인 것 같습니다. 👍
headF1rst
approved these changes
Nov 17, 2022
8장 - 의존성 관리하기/이준석.md
Outdated
Contributor
There was a problem hiding this comment.
한번에 답을 내리지 않고 여러번 고민하는 모습 좋습니다 🔥
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.