docs: LHCb Workflows and Commands#125
Open
AcquaDiGiorgio wants to merge 4 commits intoDIRACGrid:mainfrom
Open
Conversation
1 task
aldbr
requested changes
Mar 10, 2026
Contributor
aldbr
left a comment
aldbr
left a comment
There was a problem hiding this comment.
Thanks! The approach sounds good. A few comments though:
-
I think it would be interesting to have, for each type of jobs:
- left: current XML workflow
- right: the CWL + pre/post process equivalent
-
Could you add a very brief description of each module please?
-
AnalyseXMLSummary cannot work in
ProcessingI think because it needs to set some file status. So in the new workflow, we would need to have it in a post process step. We could potentially have a check withinLbRunAppas we said, to fail the workflow before it starts executing further steps. -
BookkeepingReport and WorkflowAccounting would need modifications (there will process multiple app outputs at once, this needs to appear)
AcquaDiGiorgio
force-pushed
the
issue-112-doc-lhcb-workflows
branch
from
c2ac24f to
83bf433
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #112
Apparantly, Git does not support ELK as a mermaid renderer...