feat(JobWrapper): Report the status of the job to DiracX#111
Merged
aldbr merged 19 commits intoDIRACGrid:mainfrom Mar 11, 2026
Merged
feat(JobWrapper): Report the status of the job to DiracX#111aldbr merged 19 commits intoDIRACGrid:mainfrom
aldbr merged 19 commits intoDIRACGrid:mainfrom
Conversation
Loxeris
force-pushed
the
diracx-job-statuses
branch
from
71983e2 to
2ff453b
Compare
Loxeris
force-pushed
the
diracx-job-statuses
branch
from
2ff453b to
140b8bc
Compare
aldbr
requested changes
Feb 23, 2026
Loxeris
force-pushed
the
diracx-job-statuses
branch
from
4e793fe to
ae4abc4
Compare
Loxeris
force-pushed
the
diracx-job-statuses
branch
from
a6ac83f to
c7b7188
Compare
Loxeris
commented
Mar 4, 2026
Member
Author
|
Tested and working on CTAO certification instance |
aldbr
requested changes
Mar 10, 2026
Loxeris
force-pushed
the
diracx-job-statuses
branch
from
c0f8f4d to
726cd8f
Compare
aldbr
requested changes
Mar 11, 2026
src/dirac_cwl/job/job_report.py
Outdated
| class JobReport: | ||
| """JobReport.""" | ||
|
|
||
| def __init__(self, job_id: int, source: str, client: AsyncDiracClient | None) -> None: |
Contributor
There was a problem hiding this comment.
I think the client is mandatory here.
Also, you are acting as if the client was mandatory already.
Suggested change
| def __init__(self, job_id: int, source: str, client: AsyncDiracClient | None) -> None: | |
| def __init__(self, job_id: int, source: str, client: AsyncDiracClient) -> None: |
Member
Author
There was a problem hiding this comment.
Right! I had set the client=None in the JobWrapper for local but it would make sense to just use the _diracx_client
aldbr
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reports the status of the job to DiracX using
diracx-api.closes #83