Fix data loss in gridded_skill with binsize parameter #543
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #157
When using the
binsizeparameter ingridded_skill()without explicitly defining bin edges, the auto-generated bins don't cover the full spatial range of the data. This causes data points at the boundaries to be excluded from all bins, resulting in data loss.Example
With track data spanning from latitude 31.4° to 65.62°, using
binsize=0.25without explicit bin edges causes approximately 4° of data (~400 km of satellite data) to be excluded.Solution
Modified
_add_spatial_grid_to_df()insrc/modelskill/comparison/_utils.pyto:Key Changes
Testing
test_gridded_skill_binsize_no_data_lossverifies all data points are includedCommits