fix: add notranslate support to some UI components
#462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yinanazhou
approved these changes
Dec 15, 2025
Member
yinanazhou
left a comment
yinanazhou
left a comment
There was a problem hiding this comment.
Could you add notranslate in the first two commits? It's good to go once thats done.
- Add new SCSS utilities for handling RTL exceptions when `direction: ltr` - Apply the new force-rtl helpers to pagination and the navbar search to prevent numbering issues and correct text direction behavior.
PouyaMohseni
force-pushed
the
notranslate-ui
branch
from
d95b2d1 to
bdd69bd
Compare
Contributor
Author
|
@yinanazhou, could you please review the last commit too? Thank you. |
yinanazhou
reviewed
Dec 19, 2025
Member
yinanazhou
left a comment
yinanazhou
left a comment
There was a problem hiding this comment.
Can you move .force-ltr and .force-rtl out of the nest?
Contributor
Author
|
It is in done in a commit in PR #448 . |
Member
|
In this case, can you close this one and migrate the commits to the PR you mentioned? |
Contributor
Author
|
I will close this and migrate them, but I though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.