qa: 오류사항 대응 #87
Merged
qa: 오류사항 대응 #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wongbingg
approved these changes
Jun 8, 2025
Collaborator
wongbingg
left a comment
wongbingg
left a comment
There was a problem hiding this comment.
상진님 구현내용 모두 확인했습니다 ~! 고생하셨습니다 👍
Comment on lines
-53
to
-56
| public static func == (lhs: Post, rhs: Post) -> Bool { | ||
| lhs.title == rhs.title && | ||
| lhs.organization == rhs.organization && | ||
| lhs.postUrlString == rhs.postUrlString |
Collaborator
There was a problem hiding this comment.
동등연산시 이제 모든 값을 비교하게 되겠네요! 👍
Comment on lines
+29
to
+33
| private let disposeBag = DisposeBag() | ||
| private let childCompletedSubject = PublishSubject<Post>() | ||
| var childCompletedObservable: Observable<Post> { | ||
| childCompletedSubject.asObservable() | ||
| } |
Collaborator
There was a problem hiding this comment.
자식 Coordinator 에서 관리하는 postEditObservable을 구독해서 변경사항을 현재 Coordinator 에서 처리하도록
구현되었네요! PostDetail 과 PostUpload 간 데이터 전달 흐름이 잘 이루어진 것 같아요!
저의 경우 배너관리 화면에서 비슷한 구현을 Stream 이란 객체를 따로 만들어 처리를 했었는데요, 두 방법 중 더 좋은 방법을 고민해서 추후 하나로 통일 해보면 컨벤션을 유지하기 좋을 것 같아요 👍
Member
Author
There was a problem hiding this comment.
넵 좋습니다. 다음 작업 진행할 때 한번 비교해보고 말씀 드리겠습니다!
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈 번호
📘 작업 유형
📙 작업 내역 (구현 내용 및 작업 내역을 기재합니다.)
📋 체크리스트 (PR을 올리기 전에 스스로 확인해봐요!)