Conversation
The new tag and selector fields must not be included in the msgpack messages sent towards the backend, as they will not be expected by the receiving side.
Contributor
|
as this integration tested already and the changes were explained reasonably, this is accepted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the following changes:
InputObservationstruct do not end up in the msgpack messages. The backend is not prepared to see them in the input.Note: For the reconnects, the intention here is explicitly not to buffer all observations to ensure we don't lose any single one if the backend goes away. That is a much bigger task maybe not to be tackled here. In this case, we simply want to trigger some kind of reconnect to have a working
Connto a backend expected to be back up again, e.g. for short and temporary backend outages like restarts.This is still much better than never getting a chance to ever reconnect, as it was the case before.