feat: add model, relations for organisational units #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babslgam
force-pushed
the
feat/add-schema-for-org-unit
branch
from
bdd2396 to
2c34e1c
Compare
- add new orga unit type - add metadata field for orga unit
populate orga unit metadatafield populate orga unit to unit relations correctly
Contributor
postgres has range types (daterange and tstzrange), which allow querying for overlaps. maybe something to try in a follow-up pr. |
stefanprobst
changed the title
Comment on lines
8
to
20
| export const organisationalUnitTypes = [ | ||
| "body", | ||
| "consortium", | ||
| "institution", | ||
| "umbrella_consortium", | ||
| ] as const; | ||
| export const organisationalUnitStatus = [ | ||
| "cooperating_partner", | ||
| "member", | ||
| "national_coordinating_institution", | ||
| "national_representative_institution", | ||
| "partner_institution", | ||
| ] as const; |
Contributor
There was a problem hiding this comment.
should these also live in lookup tables?
Contributor
Author
There was a problem hiding this comment.
@stefanprobst i guess yes. should we also use uuid7 in lookuptable id columns or opt for smallint?
Contributor
There was a problem hiding this comment.
let's use uuidv7 everywhere.
update schema, initial migration and seed script
- adds lookuptables for organisational unit types and status - adds regional hub type - adapts initial migration to seed type and status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
todo:
supersedes #26