Skip to content

Conversation

@andreas-hilti
Copy link
Contributor

@andreas-hilti andreas-hilti commented Jul 26, 2025

Fixes #267

builds upon #268

also fixes an issue with deserialization of localized DateTime

@andreas-hilti andreas-hilti force-pushed the fix/hyphens-in-reference-category branch 3 times, most recently from 1b3d0bf to 1a4ce41 Compare July 26, 2025 16:42
Signed-off-by: andreas hilti <[email protected]>
@andreas-hilti andreas-hilti force-pushed the fix/hyphens-in-reference-category branch from 1a4ce41 to 90f311b Compare July 26, 2025 16:46
@andreas-hilti andreas-hilti marked this pull request as ready for review July 26, 2025 16:51
@andreas-hilti andreas-hilti requested a review from a team as a code owner July 26, 2025 16:51
@mtsfoni
Copy link
Member

mtsfoni commented Jul 27, 2025

This topic is a little much.
I understand with this PR we can read underscore as well as hyphen and output underscore? Is that correct?

Stupid Question: Would outputting it with a hyphen make more sense, since that seems to be the general naming convention at SPDX for those things?

@andreas-hilti andreas-hilti force-pushed the fix/hyphens-in-reference-category branch from b5c9eca to 6c9756c Compare July 27, 2025 20:38
@andreas-hilti
Copy link
Contributor Author

This topic is a little much.

I hope we are done with it afterwards for a while...

I understand with this PR we can read underscore as well as hyphen and output underscore? Is that correct?

Yes, this is the idea.

Stupid Question: Would outputting it with a hyphen make more sense, since that seems to be the general naming convention at SPDX for those things?

There are no stupid questions, I focused mainly to get main merged into it. Xml was already using hyphen; I have now adapted Json as well.

@andreas-hilti andreas-hilti force-pushed the fix/hyphens-in-reference-category branch from 6c9756c to e410329 Compare July 28, 2025 04:03
@mtsfoni mtsfoni merged commit ae6e8a8 into CycloneDX:main Aug 10, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ExternalRefCategory 'PACKAGE_MANAGER' is not compliant with SPDX 2.2 specification

3 participants