Skip to content

Conversation

@andreas-hilti
Copy link
Contributor

No description provided.

@andreas-hilti andreas-hilti marked this pull request as draft August 26, 2024 21:25
@andreas-hilti
Copy link
Contributor Author

@mtsfoni This is just a very early and uncleaned version of what I had in mind in terms consistency tests for the different serializations. Some checks are passing; most are failing, due to various reasons (haven't yet studied the results). Some might be actual errors, for some the input might just differ, ...

@andreas-hilti
Copy link
Contributor Author

andreas-hilti commented Aug 30, 2024

With all the current changes, there are 4 issues for the json protobuf tests:

  • valid-attestation (signature, timestamps)
  • valid-license-expression (hashes, bom-ref for license expression not supported)
  • valid-metadata-lifecycle (issue serializing lifecycle)
  • valid-metadata-tool (issue with serialization of components and services for tools)

@andreas-hilti andreas-hilti changed the title Add tests for consistency between JSON and protobuf serialization Add tests for consistency between JSON, xml, and protobuf serialization Aug 31, 2024
@andreas-hilti andreas-hilti force-pushed the cdx1.6_consistency_tests branch from ea066b5 to 4ec3aad Compare August 31, 2024 17:05
@andreas-hilti
Copy link
Contributor Author

andreas-hilti commented Aug 31, 2024

With all the current changes there is only 1 issue for the xml json tests:

  • valid-bom (different content)

Signed-off-by: andreas hilti <[email protected]>
@andreas-hilti andreas-hilti force-pushed the cdx1.6_consistency_tests branch from 9d2d116 to 70cc397 Compare September 14, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant