Skip to content

Conversation

@andrewazores
Copy link
Contributor

See #166

@andrewazores andrewazores marked this pull request as draft August 9, 2025 20:02
@andrewazores
Copy link
Contributor Author

@CyberTimon work in progress - there are a lot of detected deficiencies, and I don't have the time to go through everything right now and fix things up. A lot of it are just simple warnings about unused variables and imports etc., but there are some actual concerns such as misuse of React hooks as we were discussing elsewhere:

   290:31  warning  React Hook useCallback received a function whose dependencies are unknown. Pass an inline function instead                                                                                                                                                                       react-hooks/exhaustive-deps
   424:5   warning  React Hook useCallback has unnecessary dependencies: 'setActiveAiPatchContainerId' and 'setActiveAiSubMaskId'. Either exclude them or remove the dependency array                                                                                                                react-hooks/exhaustive-deps
   682:28  warning  React Hook useCallback received a function whose dependencies are unknown. Pass an inline function instead                                                                                                                                                                       react-hooks/exhaustive-deps
   698:45  warning  React Hook useCallback received a function whose dependencies are unknown. Pass an inline function instead                                                                                                                                                                       react-hooks/exhaustive-deps
   710:25  warning  React Hook useCallback received a function whose dependencies are unknown. Pass an inline function instead                                                                                                                                                                       react-hooks/exhaustive-deps
  1538:67  warning  The ref value 'loaderTimeoutRef.current' will likely have changed by the time this effect cleanup function runs. If this ref points to a node rendered by React, copy 'loaderTimeoutRef.current' to a variable inside the effect, and use that variable in the cleanup function  react-hooks/exhaustive-deps
  1540:6   warning  React Hook useEffect has missing dependencies: 'handleRefreshFolderTree' and 'handleSelectSubfolder'. Either include them or remove the dependency array                                                                                                                         react-hooks/exhaustive-deps
  1875:6   warning  React Hook useEffect has a missing dependency: 'selectedImage'. Either include it or remove the dependency array                                                                                                                                                                 react-hooks/exhaustive-deps
  140:3   error    React Hook "useEffect" is called conditionally. React Hooks must be called in the exact same order in every component render  react-hooks/rules-of-hooks
  144:6   warning  React Hook useEffect has a missing dependency: 'draggingPointIndex'. Either include it or remove the dependency array         react-hooks/exhaustive-deps
  146:3   error    React Hook "useEffect" is called conditionally. React Hooks must be called in the exact same order in every component render  react-hooks/rules-of-hooks
  231:3   error    React Hook "useEffect" is called conditionally. React Hooks must be called in the exact same order in every component render  react-hooks/rules-of-hooks
  244:6   warning  React Hook useEffect has a missing dependency: 'handleMouseMove'. Either include it or remove the dependency array            react-hooks/exhaustive-deps
  149:6   warning  React Hook useEffect has a missing dependency: 'showOriginal'. Either include it or remove the dependency array                    react-hooks/exhaustive-deps
  174:40  warning  React Hook useCallback received a function whose dependencies are unknown. Pass an inline function instead                         react-hooks/exhaustive-deps
  280:6   warning  React Hook useEffect has a missing dependency: 'adjustments'. Either include it or remove the dependency array                     react-hooks/exhaustive-deps
  312:6   warning  React Hook useEffect has a missing dependency: 'adjustments'. Either include it or remove the dependency array                     react-hooks/exhaustive-deps
  341:5   warning  React Hook useCallback has a missing dependency: 'adjustments.orientationSteps'. Either include it or remove the dependency array  react-hooks/exhaustive-deps
  367:25  error    React Hook "useMemo" is called conditionally. React Hooks must be called in the exact same order in every component render         react-hooks/rules-of-hooks
  150:6   warning  React Hook useEffect has a missing dependency: 'comfyUiAddress'. Either include it or remove the dependency array  react-hooks/exhaustive-deps
  543:8   warning  React Hook useMemo has an unnecessary dependency: 'isAiEditing'. Either exclude it or remove the dependency array     react-hooks/exhaustive-deps
  674:7   warning  React Hook useCallback has a missing dependency: 'isToolActive'. Either include it or remove the dependency array     react-hooks/exhaustive-deps
  708:7   warning  React Hook useCallback has a missing dependency: 'isToolActive'. Either include it or remove the dependency array     react-hooks/exhaustive-deps
  782:8   warning  React Hook useCallback has a missing dependency: 'imageRenderSize'. Either include it or remove the dependency array  react-hooks/exhaustive-deps
  802:8   warning  React Hook useCallback has a missing dependency: 'isToolActive'. Either include it or remove the dependency array     react-hooks/exhaustive-deps
  172:6   warning  React Hook useEffect has missing dependencies: 'handleFinishRename' and 'setCustomEscapeHandler'. Either include them or remove the dependency array. If 'setCustomEscapeHandler' changes too often, find the parent component that defines it and wrap that definition in useCallback  react-hooks/exhaustive-deps
  114:6   warning  React Hook useEffect has missing dependencies: 'customH' and 'customW'. Either include them or remove the dependency array  react-hooks/exhaustive-deps
  158:6   warning  React Hook useEffect has missing dependencies: 'handleFinishRename' and 'setCustomEscapeHandler'. Either include them or remove the dependency array. If 'setCustomEscapeHandler' changes too often, find the parent component that defines it and wrap that definition in useCallback  react-hooks/exhaustive-deps
  107:6   warning  React Hook useEffect has a missing dependency: 'displayValue'. Either include it or remove the dependency array  react-hooks/exhaustive-deps
/home/work/workspace/RapidRAW/src/hooks/useHistoryState.tsx
/home/work/workspace/RapidRAW/src/hooks/useImageRenderSize.tsx
  53:6   warning  React Hook useEffect has missing dependencies: 'renderSize.height' and 'renderSize.width'. Either include them or remove the dependency array  react-hooks/exhaustive-deps
/home/work/workspace/RapidRAW/src/hooks/useKeyboardShortcuts.tsx
/home/work/workspace/RapidRAW/src/hooks/useKeydown.tsx
/home/work/workspace/RapidRAW/src/hooks/usePresets.ts
   44:32  warning  React Hook useCallback received a function whose dependencies are unknown. Pass an inline function instead  react-hooks/exhaustive-deps
/home/work/workspace/RapidRAW/src/hooks/useThumbnails.tsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant