Skip to content

Hide bot consoles unless we debug. #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Archiatrus wants to merge 1 commit into
base: Dev
Choose a base branch
from
Open

Hide bot consoles unless we debug. #133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/sc2laddercore/ToolsWindows.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ void StartBotProcess(const BotConfig &Agent, const std::string &CommandLine, uns
NULL);

HANDLE stdoutfile = NULL;
DWORD flags;
if (Agent.Debug)
{
std::string stdoutFile = Agent.RootPath + "/data/stdout.log";
Expand All @@ -36,11 +37,15 @@ void StartBotProcess(const BotConfig &Agent, const std::string &CommandLine, uns
OPEN_ALWAYS,
FILE_ATTRIBUTE_NORMAL,
NULL);
flags = NORMAL_PRIORITY_CLASS | CREATE_NEW_CONSOLE; // Showing the console is just a visual indicator that the bot started. Not needed if we do not debug.
}
else
{
flags = NORMAL_PRIORITY_CLASS | CREATE_NO_WINDOW;
}

PROCESS_INFORMATION processInformation;
STARTUPINFO startupInfo;
DWORD flags = NORMAL_PRIORITY_CLASS | CREATE_NEW_CONSOLE; //CREATE_NO_WINDOW <-- also possible, but we don't see easily if bot is still running.

ZeroMemory(&processInformation, sizeof(PROCESS_INFORMATION));
ZeroMemory(&startupInfo, sizeof(STARTUPINFO));
Expand Down