fix: attach pdfs to reports #197
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
introduces `IntelAPIClient.get_report_pdf(report_id)` in order to expose the falconpy `Intel.get_report_pdf()` function.
Uses the newly exposed `IntelAPIClient.get_report_pdf(report_id)` function to download Crowdstrike-report attachments and includes them as `report-file` attachments (alongside the url)
In an as yet undetermined/undiagnosed scenario, `get_pdf_report(...)` returns a `dict` and thereby causes an error in converting the expect byte array to an IO stream. This commit: - ensures a `pdfreport` is in fact a `byte` array before attempting upload to misp via an IO stream. - reverts to the original (no `add_attributed( ..., data=...`) if `pdfreport` is not a `byte` array generation of `attachments`
- Removed unnecessary `attributes` list and directly added attributes to `rpt` - Improved handling of `attachments` for various report types: - CSA and CSIT `report.details` contains `attachments` - CSECR, CSDR, CSID `report` contains `attachments`)
CSECR = "Courtesy Report" CSID = "Intrusion Digest"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #190
Currently, when MISP report objects are being created, the report-file object includes only the url for the PDF of the report, and not the actual data.
This PR: