Allow class inheritance determination for enums#16
Merged
Crell merged 2 commits intoCrell:masterfrom Mar 6, 2026
Merged
Conversation
agustingomes
force-pushed
the
enum-implementing-interface
branch
from
c3798ff to
e949de1
Compare
Crell
reviewed
Mar 2, 2026
Crell
reviewed
Mar 2, 2026
agustingomes
force-pushed
the
enum-implementing-interface
branch
from
e949de1 to
93f1875
Compare
Contributor
Author
|
@Crell Thank you for the review and the suggestions. I applied them. |
Crell
reviewed
Mar 2, 2026
Crell
reviewed
Mar 2, 2026
### Motivation In the scope of [a downstream project issue](Crell/Serde#10), It was noticed that in cases where an enum implemented an interface, the interface attributes could not be read. This change allows `ReflectionEnum` to retrieve such information if it exists
agustingomes
force-pushed
the
enum-implementing-interface
branch
from
93f1875 to
829d9cc
Compare
Crell
reviewed
Mar 6, 2026
Owner
|
All set, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Read enum implemented interfaces and its attributes
Motivation and context
In the scope of a downstream project issue, It was noticed that in cases where an enum implemented an interface, the interface attributes could not be read.
This change allows
ReflectionEnumto retrieve such information if it exists.How has this been tested?
Unit test case has been added to existing test
Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist:
Go over all the following points, and put an
xin all the boxes that apply.Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.