Introducing a build system (PIP + CMake + scikit-build) #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onform with new upcoming build structure.
…ling with pip and Meson
…as a pip package by running pip install -e . --no-build-isolation. You can then simply call commander4 globally.
… not cloned with the ducc0 submodule.
…e Python frontend now has dynamic loading of correct CPU architecture. This means it's now safe to run make across different CPUs without re-building.
…code must be '1 level up', and we can't import individual functions (see changes to e.g. scan_TOD.py for example).
…r developer install
…nstalled also for non-editable installs, which isn't ideal but ohwell.
…e install + MPI creates race conditions during import (because of the stupid .pth files that call a loading script).
jgslunde
force-pushed
the
dev-restructuring-build-cmake
branch
from
dbaa54d to
3bd8a6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pip install .)pip install -e .Note that a lot of the earlier commits was a Meson + Ninja build setup, but I went away from this after realizing it didn't work properly with editable installs and MPI in combination (race condition upon import).