Ported walletd integration tests from Groovy/Spock to Java/JUnit
#297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msgilligan
requested changes
Jan 18, 2026
Member
msgilligan
left a comment
msgilligan
left a comment
There was a problem hiding this comment.
Thanks! This is pretty close.
I am not seeing any errors about multiple logging providers on either my dev laptop or on GitHub Actions. Are you sure you are still seeing that problem?
Also please rebase+squash.
cj-btc-walletd/src/test/java/org/consensusj/daemon/micronaut/ApplicationTest.java
Show resolved
Hide resolved
cj-btc-walletd/src/test/java/org/consensusj/daemon/micronaut/ApplicationTest.java
Show resolved
Hide resolved
cj-btc-walletd/src/test/groovy/org/consensusj/daemon/micronaut/ApplicationTest.java
Outdated
Show resolved
Hide resolved
cj-btc-walletd/src/test/groovy/org/consensusj/daemon/micronaut/ApplicationTest.java
Outdated
Show resolved
Hide resolved
cj-btc-walletd/src/test/groovy/org/consensusj/daemon/micronaut/ApplicationTest.java
Outdated
Show resolved
Hide resolved
cj-btc-walletd/src/test/groovy/org/consensusj/daemon/micronaut/ApplicationTest.java
Outdated
Show resolved
Hide resolved
liamgilligan
force-pushed
the
walletd-junit-port
branch
2 times, most recently
from
ac5be07 to
e550f84
Compare
liamgilligan
force-pushed
the
walletd-junit-port
branch
from
e550f84 to
0a8b7c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solving issue #261
Current test names may need to be revised.
Currently, there is an unresolved bug with the
build.gradlecausing the tests to throw an error about multiple SLF4J providers.