Skip to content

Remove logging from LucideViewModel#900

Closed
egorikftp wants to merge 1 commit intomainfrom
task/remove-log-from-lucide
Closed

Remove logging from LucideViewModel#900
egorikftp wants to merge 1 commit intomainfrom
task/remove-log-from-lucide

Conversation

@egorikftp
Copy link
Member

Most of the time it reports coroutine cancelation exception 🙂


📝 Changelog

If this PR introduces user-facing changes, please update the relevant Unreleased section in changelogs:

@coderabbitai
Copy link

coderabbitai bot commented Feb 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cd2df46 and 20bdbca.

📒 Files selected for processing (1)
  • tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/lucide/LucideViewModel.kt
💤 Files with no reviewable changes (1)
  • tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/lucide/LucideViewModel.kt

Walkthrough

The Logger and its companion object were removed from LucideViewModel. All onFailure logging blocks that previously referenced LOG have been eliminated. Error handling now directly updates state and messages without logging statements. Public function signatures and types remain unchanged, with behavior remaining equivalent aside from the removal of log statements.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Remove logging from LucideViewModel' directly and specifically describes the main change—removal of logging from the specified class.
Description check ✅ Passed The description includes the changelog template with checkboxes and a brief rationale, but lacks comprehensive detail about what logging was removed or why it was problematic.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch task/remove-log-from-lucide

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@egorikftp
Copy link
Member Author

will be updated in #899

@egorikftp egorikftp closed this Feb 24, 2026
@egorikftp egorikftp deleted the task/remove-log-from-lucide branch February 24, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant