Skip to content

CMP-3843: Add check for the default value of a variable#1173

Open
Anna-Koudelkova wants to merge 1 commit intoComplianceAsCode:masterfrom
Anna-Koudelkova:CMP-3843
Open

CMP-3843: Add check for the default value of a variable#1173
Anna-Koudelkova wants to merge 1 commit intoComplianceAsCode:masterfrom
Anna-Koudelkova:CMP-3843

Conversation

@Anna-Koudelkova
Copy link
Copy Markdown
Collaborator

The downstream test case 47162 checks if the default value of the variable ocp4-var-api-min-request-timeout is 3600. Adding this check to already existing parallel testcase TestRuleVariableAnnotation.

Testcase passes on OCP 4.21:

=== RUN   TestRuleVariableAnnotation
=== PAUSE TestRuleVariableAnnotation
=== CONT  TestRuleVariableAnnotation
=== RUN   TestRuleVariableAnnotation/ocp4-configure-network-policies-namespaces
    main_test.go:5668: Rule ocp4-configure-network-policies-namespaces correctly has variable annotation: var-network-policies-namespaces-exempt-regex
=== RUN   TestRuleVariableAnnotation/ocp4-resource-requests-limits-in-statefulset
    main_test.go:5668: Rule ocp4-resource-requests-limits-in-statefulset correctly has variable annotation: var-statefulset-limit-namespaces-exempt-regex
=== RUN   TestRuleVariableAnnotation/ocp4-api-server-request-timeout
    main_test.go:5665: Variable ocp4-var-api-min-request-timeout has expected default value 3600
    main_test.go:5668: Rule ocp4-api-server-request-timeout correctly has variable annotation: var-api-min-request-timeout
--- PASS: TestRuleVariableAnnotation (0.84s)
    --- PASS: TestRuleVariableAnnotation/ocp4-configure-network-policies-namespaces (0.23s)
    --- PASS: TestRuleVariableAnnotation/ocp4-resource-requests-limits-in-statefulset (0.15s)
    --- PASS: TestRuleVariableAnnotation/ocp4-api-server-request-timeout (0.47s)
PASS
...
ok  	github.com/ComplianceAsCode/compliance-operator/tests/e2e/parallel	193.808s

@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

@Anna-Koudelkova: This pull request references CMP-3843 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

The downstream test case 47162 checks if the default value of the variable ocp4-var-api-min-request-timeout is 3600. Adding this check to already existing parallel testcase TestRuleVariableAnnotation.

Testcase passes on OCP 4.21:

=== RUN   TestRuleVariableAnnotation
=== PAUSE TestRuleVariableAnnotation
=== CONT  TestRuleVariableAnnotation
=== RUN   TestRuleVariableAnnotation/ocp4-configure-network-policies-namespaces
   main_test.go:5668: Rule ocp4-configure-network-policies-namespaces correctly has variable annotation: var-network-policies-namespaces-exempt-regex
=== RUN   TestRuleVariableAnnotation/ocp4-resource-requests-limits-in-statefulset
   main_test.go:5668: Rule ocp4-resource-requests-limits-in-statefulset correctly has variable annotation: var-statefulset-limit-namespaces-exempt-regex
=== RUN   TestRuleVariableAnnotation/ocp4-api-server-request-timeout
   main_test.go:5665: Variable ocp4-var-api-min-request-timeout has expected default value 3600
   main_test.go:5668: Rule ocp4-api-server-request-timeout correctly has variable annotation: var-api-min-request-timeout
--- PASS: TestRuleVariableAnnotation (0.84s)
   --- PASS: TestRuleVariableAnnotation/ocp4-configure-network-policies-namespaces (0.23s)
   --- PASS: TestRuleVariableAnnotation/ocp4-resource-requests-limits-in-statefulset (0.15s)
   --- PASS: TestRuleVariableAnnotation/ocp4-api-server-request-timeout (0.47s)
PASS
...
ok  	github.com/ComplianceAsCode/compliance-operator/tests/e2e/parallel	193.808s

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 8, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Anna-Koudelkova

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested a review from yuumasato April 8, 2026 11:06
@openshift-ci openshift-ci bot added the approved label Apr 8, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 8, 2026

@Anna-Koudelkova: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-serial-arm e00590a link true /test e2e-aws-serial-arm
ci/prow/e2e-rosa e00590a link true /test e2e-rosa
ci/prow/e2e-aws-parallel-arm e00590a link true /test e2e-aws-parallel-arm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants