Solve remaining unchecked and deprecation warnings #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solve remaining unchecked and deprecation warnings
| return; | ||
| } | ||
| TarArchiveEntry tarEntry = tarIn.getNextTarEntry(); | ||
| TarArchiveEntry tarEntry = tarIn.getNextEntry(); |
Member
There was a problem hiding this comment.
Have you checked this still works, i remember making this change because tar was not working for symlinks (in one of the Mac tar files)
Contributor
Author
There was a problem hiding this comment.
I didn't test it for Mac, I don't have the hardware. Could you test it?
It seems a plain case of method overloading, but I could be wrong. As far as I can see, based on the jvm.json file, only Linux uses the tar-file, Mac uses the zip-file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve remaining unchecked and deprecation warnings