Fix: suppress obsolete API warnings and CA2265 Span null checks #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
The warning is a useful thing, it is reminding me that I need to work on the backend and completely remove the obsolete code and update FinderOuter to use the new ones. 🙄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: suppressed obsolete warnings for PrivateKey/SecP256k1 and removed redundant Span null checks (CA2265). All tests pass (1354/1354) on .NET 10.0.1.\n\nChanges: updated project targets to net10.0, added #pragma to suppress CS0612 where necessary, and removed redundant Span null checks.\n\nNotes: I ran the full test suite locally and they all passed. Please review warnings for possible long-term replacements of obsolete APIs.