fix: black friday for 2025#997
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Black Friday promotional campaign for 2025, replacing hardcoded 2024 dates with dynamic date calculations based on the current year and extending promotional offers to monthly plan users.
Key changes:
- Dynamic Black Friday date calculation instead of hardcoded 2024 dates
- New promotional strategy targeting both free and monthly plan users with differentiated offers
- Integration with ThemeIsle SDK's Black Friday framework
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| inc/admin.php | Updated Black Friday promotion logic with dynamic dates, monthly plan support, SDK integration, and new helper methods |
| tests/test-admin.php | Comprehensive test suite covering all Black Friday notice scenarios including plan-specific logic and date boundaries |
| phpstan-baseline.neon | Removed PHPStan baseline entry for get_bf_notices() method type specification |
| assets/src/dashboard/parts/connected/index.js | Simplified banner visibility logic to support all eligible plan types |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
0c14b23 to
39f1008
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
inc/admin.php:718
- The
tsdk_translate_link()call on line 714 is redundant sinceadd_query_arg()on line 718 will modify the URL returned fromtsdk_translate_link(). Iftsdk_translate_link()adds query parameters, they may interfere with the email parameter. Consider callingtsdk_translate_link()after all query args are added, similar to line 1609 wheretsdk_translate_link()wrapsself::get_upgrade_base_link().
$base_url = tsdk_translate_link( $base_url );
$email = self::get_account_email();
if ( ! empty( $email ) ) {
$base_url = add_query_arg( 'email', base64_encode( $email ), $base_url );
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
82b51f3 to
3029405
Compare
3029405 to
cfe9a37
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@selul is PR is final for review |
|
🎉 This PR is included in version 4.1.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
All Submissions:
Changes proposed in this Pull Request:
Note
Like in the last year, the big banner is dimissable while the one in sidebar is not.
Closes https://github.com/Codeinwp/optimole-service/issues/1625
How to test the changes in this Pull Request:
Other information:
Note
The global notice integration will be skipped based on https://github.com/Codeinwp/optimole-service/issues/1625#issuecomment-3486542201
Translations
Here are the translation changes:
msgid "25 Nov - 03 Dec"has been removed in favor ofwp_datanative translation.Note
Some existing string like
Private saleare not translated (reference)