Skip to content

Conversation

@EricThomson
Copy link
Collaborator

Introduction to basic pytorch library tensor operations.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Shubham-Agarwall
Copy link
Collaborator

Hi, in my opinion and based on my understanding....

Overall the lesson looks great, there is enough explanation and examples. I think following changes could help the new learners.

  1. Introduction section - real world connection. The lesson explains what PyTorch is, but not clearly why learners should care. Consider adding one short real world idea.

  2. Simplify the framework comparison, PyTorch vs TensorFlow paragraph - The comparison is informative but a bit heavy for a first exposure. Please simplify if possible.

  3. Possible to add small 'Try this' prompts for students? How about adding the usual check for understanding section, maybe in the Github MD, they could solve this when they are back learning from Kaggle notebook.

  4. And, as usual, let's remind students to run or modify and run the code examples.

  5. Are we introducing Kaggle for the first time or students know about it, if not let's introduce. Do they know that they could run the code blocks right there?

Lastly, not sure if It might be worth adding one or two simple images, a tensor shape diagram or a PyTorch vs NumPy visual to improve visual appeal.

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants