-
Notifications
You must be signed in to change notification settings - Fork 12
Add initial support for SDF files #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Looks like it has some issues with package paths. Not sure how easy it is to parse those, but it's not hard for a user to make all filepaths relative. When I run it with relative paths only, it works*, but there seem to be some output issues:
I've also attached a zip file containing the original output and the fixed output. |
|
Thanks for checking it out! Addressed everything you said, pulled in this package to resolve paths. |
|
That's great! Thanks for putting this together so quickly. Like I said, long-term, it would be great if packages could also be resolved. (I've usually seen this done by reading an environment variable like |
|
Oh, do the package URIs not work? There should resolution of the URIs now. If it doesn't work, no big deal, add that to the feature list to handle soon. |
|
Looks like paths aren't resolving correctly -- its currently concatenating the path to the outputs which is correct. But when I call I get the error message |

No description provided.