Byte array handling for clj #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A-Helberg
requested changes
Jul 20, 2022
src/clojure/network/ip.cljc
Outdated
|
|
||
| #?(:clj | ||
| (defn- to-ip-byte-array [number] | ||
| (let [number (if (instance? BigInteger number) number (biginteger number)) |
There was a problem hiding this comment.
Requires a check that the number is >= 0
src/clojure/network/ip.cljc
Outdated
| (defn- to-ip-byte-array [number] | ||
| (let [number (if (instance? BigInteger number) number (biginteger number)) | ||
| bytes (seq (.toByteArray number)) | ||
| ;; If there is a sign byte, remove it |
There was a problem hiding this comment.
This should probably always be removed, and we need to explain why we remove it
src/clojure/network/ip.cljc
Outdated
| bytes (if (= (byte 0) (first bytes)) | ||
| (rest bytes) | ||
| bytes) | ||
| byte-size (count bytes) |
src/clojure/network/ip.cljc
Outdated
| (rest bytes) | ||
| bytes) | ||
| byte-size (count bytes) | ||
| should-be (if (<= byte-size 4) 4 16) |
There was a problem hiding this comment.
I don't really understand the name of this var
src/clojure/network/ip.cljc
Outdated
| (network-mask [this])) | ||
|
|
||
| #?(:clj | ||
| (defn- to-ip-byte-array [number] |
There was a problem hiding this comment.
this could be more descriptive, eg. dec-ip->byte-array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the library cannot handle the "all" ip:
0.0.0.0This resolves that issue
TODO: