Check validity of NPC enums during loading #84545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
NPC / Factions
RenechCDDA
force-pushed
the
kill_invalid_enum
branch
from
357c69e to
11411cc
Compare
github-actions
bot
added
the
Mods: Dinomod
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Auto-requesting reviews from non-collaborators: @LyleSY
RenechCDDA
force-pushed
the
kill_invalid_enum
branch
from
11411cc to
b5d0607
Compare
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Describe the solution
Legacy enum should never show up, obviously
Check during loading for invalid enums, yell if so
Change translation string for legacy attitudes to make it even-more-obvious that this is wrong.
Describe alternatives you've considered
Although
NPCATT_FLEEis a non-legacy attitude, the comment in npc.h suggests it is deprecated.It sure doesn't look that way, and it's still in NPCs.MD, so I've set it to be "allowed" right now. Simple change if we want to remove it later.
Testing
Additional context