Skip to content

Conversation

@RenechCDDA
Copy link
Member

Summary

None

Purpose of change

When removing charges from the last batch of item types, a lot of item groups had to be automatically created or converted to accommodate those changes.

Those changes were automated, but extensively reviewed both by myself and several other reviewers.

Well it's been over a year, and there have been zero found systemic errors. So clearly, if there was some problem in the script we'd have seen it by now.

Instead these warnings linger and scare the less-informed contributors by suggesting there's errors, when there are none.

Describe the solution

Delete.

Describe alternatives you've considered

We probably should never have added these comments in the first place.

Testing

If it loads it can ship. The only changes were a single regex pass.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Items: Food / Vitamins Comestibles and drinks Spawn Creatures, items, vehicles, locations appearing on map Monsters Monsters both friendly and unfriendly. Mods: Aftershock Anything to do with the Aftershock mod Mods: Xedra Evolved Anything to do with Xedra Evolved labels Jan 8, 2026
@RenechCDDA RenechCDDA force-pushed the remove_obsolete_warning_comments branch from 0f63973 to 5571904 Compare January 8, 2026 07:30
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jan 8, 2026
@Maleclypse Maleclypse merged commit 24df218 into CleverRaven:master Jan 8, 2026
24 of 28 checks passed
@RenechCDDA RenechCDDA deleted the remove_obsolete_warning_comments branch January 9, 2026 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Food / Vitamins Comestibles and drinks [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: Aftershock Anything to do with the Aftershock mod Mods: Xedra Evolved Anything to do with Xedra Evolved Monsters Monsters both friendly and unfriendly. Spawn Creatures, items, vehicles, locations appearing on map

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants