Skip to content

Conversation

@rty275
Copy link
Contributor

@rty275 rty275 commented Jan 8, 2026

Summary

Bugfixes "Coffee spawning issues"

Purpose of change

So #84518 added packaging for a lot of different things, but I noticed during gameplay that it caused multiple different kinds of coffee to be spawning in the same container. This... does fix that...

Describe the solution

I fell down a rabbit hole of learning how itemgroups work, since I was trying to figure out how to make all of the coffee in a given container spawn as the same kind of coffee. I am really quite sure that the solution that I came up with is more than a little overcomplicated, hence why I'm posting this as a draft. This does work as a solution, it genuinely does solve the problem and it could be merged, but I really do feel like there must be some simpler way that I'm missing.

Describe alternatives you've considered

I read the doc file on itemgroups until my brain hurt, and this is the best I could come up with. Very open to other suggestions.

Testing

Game loads and itemgroups spawn as desired. This does remove the raw_coffee itemgroup, but I couldn't find anywhere else in the code that it's mentioned, and I don't think itemgroups need migration, but if so, please do tell me.

Additional context

This does also notably increase the actual spawn numbers of coffee, but I presumed that would make sense as it would be strange to get a sealed can of coffee grounds that only had less than half its contents?

So I fell down a rabbit hole when it came to item groups...
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Food / Vitamins Comestibles and drinks Spawn Creatures, items, vehicles, locations appearing on map <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions labels Jan 8, 2026
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Jan 8, 2026
@BalthazarArgall
Copy link
Contributor

Hey uh... I've submitted a fix myself and I wanted to make extra sure that it's fine with you. I absolutely didn't mean this as a rugpull, basically I think I have an ever so slightly more elegant solution and it was ready to go instead of being a draft, and since you said that you were unsure about your changes...

What I could have done was to suggest my changes and you could have applied them to your PR but since I've went a different route of fixing this this would have been me basically removing all your code and replacing it with mine which I feel is not really what "suggestion" are for.

I could add you as co-author of my commit if you want but I'm not sure it'd fly. I hope the mergers can offer some guidance here.

I understand that this is partly a learning experience working with itemgroups so if you want feel free to check my PR and review it or just comment about stuff and I can explain why I've done some stuff that way or the other.

Apologies.

@rty275
Copy link
Contributor Author

rty275 commented Jan 8, 2026

Nothing to apologize for! I've already commented on your PR, but I'll just explicitly say again here that I'm totally okay with you making a PR in place of mine, I did this mostly to learn how itemgroups work in the first place, and learning your solution is also very valuable information!

I mentioned it on your PR, but I think there's a problem with how your solution is made irrespective of how much coffee actually fits within the container, since the containers you chose are different sizes. I think a possibly alternate solution instead of either of our works is to make in-line distributions in place of the separate ones I've made, but I genuinely don't know if that's more elegant or if it just ends up looking a mess. Alternatively, we trim down the number of containers to only two sizes, small and large, and each size only has containers that are of identical size.

@rty275
Copy link
Contributor Author

rty275 commented Jan 8, 2026

Closing in favor of #84554

@rty275 rty275 closed this Jan 8, 2026
@rty275 rty275 deleted the coffee-crazy branch January 9, 2026 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

astyled astyled PR, label is assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Items: Food / Vitamins Comestibles and drinks [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Spawn Creatures, items, vehicles, locations appearing on map

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants