refact: fix (almost) all shellcheck errors#997
Merged
ChrisTitusTech merged 1 commit intoChrisTitusTech:mainfrom Feb 2, 2025
Merged
refact: fix (almost) all shellcheck errors#997ChrisTitusTech merged 1 commit intoChrisTitusTech:mainfrom
ChrisTitusTech merged 1 commit intoChrisTitusTech:mainfrom
Conversation
the only files i didn't fix: - core/tabs/utils/ssh.sh (ref ChrisTitusTech#996) - core/tabs/system-setup/arch/server-setup.sh
koibtw
force-pushed
the
refact/shellcheck
branch
from
1fe60f5 to
414c757
Compare
koibtw
force-pushed
the
refact/shellcheck
branch
from
414c757 to
d93d81a
Compare
koibtw
changed the title
koibtw
force-pushed
the
refact/shellcheck
branch
from
d93d81a to
414c757
Compare
koibtw
changed the title
Collaborator
Author
|
honestly i think we should get rid of shfmt |
ChrisTitusTech
approved these changes
Feb 2, 2025
Owner
|
Agree we should probably dump shfmt. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the only files i didn't fix:
core/tabs/utils/ssh.sh#996)