feat: Void linux support#986
feat: Void linux support#986Jaredy899 wants to merge 25 commits intoChrisTitusTech:mainfrom Jaredy899:Void
Conversation
koibtw
left a comment
koibtw
left a comment
There was a problem hiding this comment.
the code looks OK. i know i'm asking for much but did you test every single thing that could break (more complex scripts) on a fresh installation? not approving for now.
|
I double checked everything and made some minor changes to ensure everything works smoothly. Ran on fresh void-xfce on proxmox. also made a change to the common-service-script as it wasn't working right with docker. But now it does. |
| runit) | ||
| "$ESCALATION_TOOL" mkdir -p "/run/runit/supervise.$1" | ||
| "$ESCALATION_TOOL" ln -sf "/etc/sv/$1" "/var/service/" | ||
| sleep 5 |
There was a problem hiding this comment.
okay. why is it sleeping here?
There was a problem hiding this comment.
gives it time to set up the supervision. I had it set at 2 but it was failing. Seems to work at 5.
There was a problem hiding this comment.
i don't really like this approach to be honest. is there no other way? i don't understand the logic here.
* chore: update copyright year (#988) * refact: minor fixes (#971) * Fix unused float handle mouse function, pub mod appstate Fix unnecessary usage of pub mod for appstate and resolve unused float handle mouse function * Resolve clippy warnings Remove explicit lifetime for floatcontent impl. Use div_ceil instead of manually calculating the rows for hints * chore(release): prepare for 25.1.10 (#991) * Update linutil.yml (#993) --------- Co-authored-by: Adam Perkowski <adas1per@protonmail.com> Co-authored-by: Jeevitha Kannan K S <ksjeevithakannan123@gmail.com> Co-authored-by: Chris Titus <contact@christitus.com>
2 participants
Type of Change
Description
Add Void Linux support for many applications, also utilizing my previous common-service-script.
Testing
Tested in Void Linux
Issues / other PRs related
Dependent on PR #985
Checklist