Skip to content

refact(brave-install): simplify script#980

Merged
ChrisTitusTech merged 2 commits intoChrisTitusTech:mainfrom
Angxddeep:Testing1
Feb 28, 2025
Merged

refact(brave-install): simplify script#980
ChrisTitusTech merged 2 commits intoChrisTitusTech:mainfrom
Angxddeep:Testing1

Conversation

@Angxddeep
Copy link
Contributor

@Angxddeep Angxddeep commented Dec 11, 2024

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Description

So the folks at Brave made an all-in-one curl script for Linux, so just using that is better than the mess we have today.

Testing

Tested and works

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

Copy link
Collaborator

@afonsofrancof afonsofrancof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@koibtw koibtw changed the title Refact:- Simplifying Brave install script refact(brave-install): simplify script Dec 17, 2024
Copy link
Collaborator

@koibtw koibtw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we should remove brave installation entirely if there's a one-line universal solution. @ChrisTitusTech ?

@lj3954
Copy link
Contributor

lj3954 commented Jan 10, 2025

i think we should remove brave installation entirely if there's a one-line universal solution. @ChrisTitusTech ?

Linutil has options to install firefox, chromium, etc, even though they're essentially the same line regardless of distro. I think it's better to keep it around.

@ChrisTitusTech ChrisTitusTech merged commit 7f82c66 into ChrisTitusTech:main Feb 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants