fix(system-cleanup): invalid trash permissions#1055
Closed
dhruvmistry2000 wants to merge 1 commit intoChrisTitusTech:mainfrom
Closed
fix(system-cleanup): invalid trash permissions#1055dhruvmistry2000 wants to merge 1 commit intoChrisTitusTech:mainfrom
dhruvmistry2000 wants to merge 1 commit intoChrisTitusTech:mainfrom
Conversation
the function was not working as it didint have sudo permission
Contributor
Author
|
|
koibtw
changed the title
Collaborator
|
the changes look good. i'm not sure if this is the correct solution though. your permissions seem to be pretty messed up |
Contributor
|
In all the testing I've done on various distros, I've not had a problem with permissions in cleanup. |
Contributor
Author
|
Ok i will check and I am closing the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the function was not working as it didint have sudo permission
Type of Change
Description
Testing
Impact
Issues / other PRs related
Additional Information
Checklist