fix(ssh-samba): Missing import of common service script#1053
Merged
ChrisTitusTech merged 1 commit intoChrisTitusTech:mainfrom Jun 20, 2025
Merged
fix(ssh-samba): Missing import of common service script#1053ChrisTitusTech merged 1 commit intoChrisTitusTech:mainfrom
ChrisTitusTech merged 1 commit intoChrisTitusTech:mainfrom
Conversation
ChrisTitusTech
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
The SSH-Samba script forgets to import the common-service-script so it fails trying to enable the sshd or samba service.
When it tries to call StartandEnableService it can't find it since it's not imported, so I just added the import.
Testing
I have tested my code and its gets through the ssh part however there is a unrelated error for samba in the input handling, once I find a fix for that I will create a separate pr.
Impact
No impact just fixes an error.
Issues / other PRs related
None
Additional Information
Not right now
Checklist