Skip to content

fix(ssh-samba): Missing import of common service script#1053

Merged
ChrisTitusTech merged 1 commit intoChrisTitusTech:mainfrom
infstate:fix-ssh-samba-bug
Jun 20, 2025
Merged

fix(ssh-samba): Missing import of common service script#1053
ChrisTitusTech merged 1 commit intoChrisTitusTech:mainfrom
infstate:fix-ssh-samba-bug

Conversation

@infstate
Copy link
Contributor

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Description

The SSH-Samba script forgets to import the common-service-script so it fails trying to enable the sshd or samba service.
When it tries to call StartandEnableService it can't find it since it's not imported, so I just added the import.

Testing

I have tested my code and its gets through the ssh part however there is a unrelated error for samba in the input handling, once I find a fix for that I will create a separate pr.

Impact

No impact just fixes an error.

Issues / other PRs related

None

Additional Information

Not right now

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

@ChrisTitusTech ChrisTitusTech merged commit aa0f6a7 into ChrisTitusTech:main Jun 20, 2025
4 checks passed
@infstate infstate deleted the fix-ssh-samba-bug branch June 21, 2025 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants