This repository was archived by the owner on May 27, 2021. It is now read-only.
Rename dark-placeholder: to dark: for placeholderColor and new dark-divide for divideColor#21
Open
abdusfauzi wants to merge 7 commits intoChanceArthur:masterfrom
Open
Rename dark-placeholder: to dark: for placeholderColor and new dark-divide for divideColor#21abdusfauzi wants to merge 7 commits intoChanceArthur:masterfrom
abdusfauzi wants to merge 7 commits intoChanceArthur:masterfrom
Conversation
Change dark-placeholder css-prefix to dark on return value, to be use specific for `placeholder`
New: dark-divide variant specific for divide-color-{x} utility
Update readme with dark-placeholder (updated) & dark-divide manual
abdusfauzi
changed the title
Owner
|
Wondering if maybe we should include both methods to maintain compatibility with the old way of doing this. Thoughts? |
Author
|
@ChanceArthur sounds good to me. I’m sure a lot of people has been using the old way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous update
dark-placeholderwas suggested to text-color utility.I renamed the variant return value from
dark-placeholder:todark:and if used on placeholderColor, it will produce shorter and .mode-dark compatible placeholder's color.