fix: make send_toast an async function#2809
Open
Br1an67 wants to merge 1 commit intoChainlit:mainfrom
Open
Conversation
The send_toast method calls self.emit() which is async, but was not declared async itself, causing the coroutine to never be awaited. This aligns with the existing test expectations which already use await.
Br1an67
requested review from
asvishnyakov,
hayescode and
sandangel
as code owners
dosubot
bot
added
size:XS
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make
send_toastanasyncmethod in bothBaseChainlitEmitterandChainlitEmitter.Closes #2803
Why
send_toastcallsself.emit()which is async, but was not declaredasyncitself. This means the coroutine returned byemit()was never awaited. The existing tests already expectsend_toastto be awaitable (await emitter.send_toast(...)).Changes
backend/chainlit/emitter.py: Addedasyncto bothsend_toastdefinitions andawaittheemit()callTesting
test_send_toast*tests passSummary by cubic
Make send_toast async in BaseChainlitEmitter and ChainlitEmitter, and await emit() to prevent unawaited coroutine errors. Aligns with existing tests that await send_toast and ensures toast messages are properly emitted.
Written for commit fb81652. Summary will update on new commits.