Hurricup/fixes #3145
Hurricup/fixes #3145
Conversation
📝 WalkthroughWalkthroughThis PR updates copyright years to 2026, improves documentation and spelling across multiple files, refactors Kotlin string literals using template syntax, updates test macros for run configuration serialization, and adds new error patterns to the YouTrack workflow for issue tracking. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In
`@plugin/common/src/main/java/com/perl5/lang/perl/idea/intellilang/PerlDefaultInjectionMarkers.kt`:
- Line 225: Replace the invalid Kotlin string syntax used for the "XSLT" mapping
in PerlDefaultInjectionMarkers (the entry currently using $$"$XSLT"); update the
value to use an escaped dollar sign in a normal Kotlin string (i.e. use
"\$XSLT") so the code compiles; locate the mapping for "XSLT" in the
PerlDefaultInjectionMarkers.kt file and change the right-hand string
accordingly.
| "XPATH" to "XPath", | ||
| "XPATH2" to "XPath2", | ||
| "XSLT" to "\$XSLT", | ||
| "XSLT" to $$"$XSLT", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# Find build configuration files to determine Kotlin version
find . -type f \( -name "build.gradle*" -o -name "pom.xml" -o -name "gradle.properties" -o -name "build.gradle.kts" \) | head -20Repository: Camelcade/Perl5-IDEA
Length of output: 829
🏁 Script executed:
# Read the file in question around line 225
cat -n plugin/common/src/main/java/com/perl5/lang/perl/idea/intellilang/PerlDefaultInjectionMarkers.kt | sed -n '210,235p'Repository: Camelcade/Perl5-IDEA
Length of output: 675
🏁 Script executed:
# Search for Kotlin version constraints
rg "kotlin" --type gradle --type xml -i | grep -E "(version|target)" | head -20Repository: Camelcade/Perl5-IDEA
Length of output: 46
🏁 Script executed:
# Check gradle.properties for Kotlin version
cat gradle.properties | grep -i kotlinRepository: Camelcade/Perl5-IDEA
Length of output: 102
🏁 Script executed:
# Check the root build.gradle.kts for Kotlin plugin
head -50 build.gradle.kts | grep -i kotlinRepository: Camelcade/Perl5-IDEA
Length of output: 204
🏁 Script executed:
# Search for kotlin version in gradle files
rg "kotlin.*=.*[0-9]" | head -20Repository: Camelcade/Perl5-IDEA
Length of output: 46
🏁 Script executed:
# Check the specific module's build file
cat plugin/common/build.gradle.kts | grep -i kotlinRepository: Camelcade/Perl5-IDEA
Length of output: 93
🏁 Script executed:
# Search for $$" pattern in the codebase
rg '\$\$"' --type ktRepository: Camelcade/Perl5-IDEA
Length of output: 90
🏁 Script executed:
# Check if there are other similar lines in the same file
rg 'to "\$' plugin/common/src/main/java/com/perl5/lang/perl/idea/intellilang/PerlDefaultInjectionMarkers.ktRepository: Camelcade/Perl5-IDEA
Length of output: 46
🏁 Script executed:
# Look at more context around line 225 to understand the data structure
cat -n plugin/common/src/main/java/com/perl5/lang/perl/idea/intellilang/PerlDefaultInjectionMarkers.kt | sed -n '200,230p'Repository: Camelcade/Perl5-IDEA
Length of output: 1005
🏁 Script executed:
# Search for $$" pattern without file type restriction
rg '\$\$"'Repository: Camelcade/Perl5-IDEA
Length of output: 23660
🏁 Script executed:
# Check the whole file to see context and structure
wc -l plugin/common/src/main/java/com/perl5/lang/perl/idea/intellilang/PerlDefaultInjectionMarkers.ktRepository: Camelcade/Perl5-IDEA
Length of output: 163
🏁 Script executed:
# Get the beginning of the file to understand the data structure
head -30 plugin/common/src/main/java/com/perl5/lang/perl/idea/intellilang/PerlDefaultInjectionMarkers.ktRepository: Camelcade/Perl5-IDEA
Length of output: 1083
Fix invalid string syntax; $$"..." is not valid Kotlin.
The syntax $$"$XSLT" will not compile in Kotlin 2.3.0 or any prior version. Use "\$XSLT" to include a literal dollar sign.
Correct syntax
- "XSLT" to $$"$XSLT",
+ "XSLT" to "\$XSLT",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "XSLT" to $$"$XSLT", | |
| "XSLT" to "\$XSLT", |
🤖 Prompt for AI Agents
In
`@plugin/common/src/main/java/com/perl5/lang/perl/idea/intellilang/PerlDefaultInjectionMarkers.kt`
at line 225, Replace the invalid Kotlin string syntax used for the "XSLT"
mapping in PerlDefaultInjectionMarkers (the entry currently using $$"$XSLT");
update the value to use an escaped dollar sign in a normal Kotlin string (i.e.
use "\$XSLT") so the code compiles; locate the mapping for "XSLT" in the
PerlDefaultInjectionMarkers.kt file and change the right-hand string
accordingly.
|
Summary by CodeRabbit
Documentation
Chores
✏️ Tip: You can customize this high-level summary in your review settings.