Skip to content

Conversation

@Hoog-V
Copy link
Member

@Hoog-V Hoog-V commented Jan 30, 2025

Removal custom ROS2 camera node & CI

As listed in the TODO, I removed the custom ROS2 camera node and replaced it with v4l2_camera (see the gitlab repo).

This brings in several advantages:

  1. Default implementation means easy to integrate with other ros2 packages
  2. CI integration now tests whether the ROS2 code still compiles

The documentation has been updated to make sure it still runs.

@Hoog-V Hoog-V changed the title [Enhancement] Remove custom ROS2 camera node & CI/CD [Enhancement] Remove custom ROS2 camera node & CI Jan 30, 2025
@Hoog-V Hoog-V requested a review from ducroq January 30, 2025 19:29
@Hoog-V
Copy link
Member Author

Hoog-V commented Jan 31, 2025

@ducroq when approved, merge it right away. Otherwise you can't test the face mesh package (as this is tied in as dependency on main branch!)

Copy link
Contributor

@ducroq ducroq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

@ducroq ducroq merged commit c2903db into main Feb 1, 2025
2 checks passed
@ducroq ducroq deleted the ros2_update branch February 1, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants