Skip to content

Conversation

@r1d3th3wav3s
Copy link
Contributor

  • Improved logging
  • Adds detection of various file types
  • Improved detection of UTF-8 / ASCII files
  • Adds a unit test for UTF-8 files

Copy link
Member

@psrok1 psrok1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if you also provide test files for added extensions: see https://github.com/CERT-Polska/karton-classifier/tree/master/tests/testdata

PS.: I've fixed few simple errors and linting + merged it with upstream changes, so please make a pull before applying yours.

@r1d3th3wav3s
Copy link
Contributor Author

updated my pull request (removed some too specific detections, added unit-tests9

Copy link
Member

@nazywam nazywam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
One small note - I think we should stick to - instead of _ in the "kind" fields. There isn't an official guide per se but looking at other filetypes we've used only - so far

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants