Fix bug - output truncation #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependencies updated: - Java: 8 → 11 - JDOM: 1.1.3 → JDOM2 2.0.6.1 - Commons CLI: 1.4 → 1.9.0 - Commons Lang: 3.12.0 → 3.17.0 Plugins updated: - Maven Assembly: 3.1.1 → 3.7.1 - Maven Surefire: 3.2.5 → 3.5.2 Java 11 requirement: The following dependencies require Java 11 as minimum: - JUnit Jupiter 5.11.4 (requires Java 11+) - Spotless Maven Plugin 2.44.0 (requires Java 11+) Documentation: - Updated README Code changes: - Refactored AndroidXmlOutputter to use composition instead of inheritance since JDOM2's XMLOutputter cannot be subclassed.
Remove incorrect code that stripped the last 2 bytes from the output file. The original comment said 'Strip double line break' but this was actually removing the final '>' character and newline from the closing tag. Changes: - Fixed Main.java to write complete file content - Added try-with-resources for FileOutputStream to fix resource leak - Added integration test with closing_tag_input.xml and closing_tag_expected.xml
mdzyuba
force-pushed
the
fix_bug_output_truncation
branch
from
62b0a83 to
6dbb0b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix depends on PR#5 and PR#7.