Add sets for performers#54
Merged
Bukashk0zzz merged 8 commits intoBukashk0zzz:masterfrom Dec 23, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for sets (collections of related products) to the YML Generator. The implementation follows the existing pattern for categories and currencies, allowing offers to be grouped into sets via set IDs.
Key changes:
- Introduces a new
Setmodel class with id, name, and url properties - Adds set ID fields to offers (both singular
setIdand pluralsetsId) - Implements set generation in the XML output with conditional rendering based on whether sets are provided
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/Model/Set.php | New model class representing a set with id, name, and url properties |
| src/Model/Offer/AbstractOffer.php | Adds setId and setsId properties with getters/setters, and integrates set IDs into the XML header options |
| src/Generator.php | Imports Set class, updates generate() signature to accept sets parameter, and adds methods to render sets in XML output |
| README.md | Adds example code demonstrating how to create and use sets |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
Bukashk0zzz
requested changes
Dec 22, 2025
Contributor
Author
|
@Bukashk0zzz Sorry, I was in a hurry... I corrected the code style. |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.