Skip to content

Add sets for performers#54

Merged
Bukashk0zzz merged 8 commits intoBukashk0zzz:masterfrom
AlexSrc-2:master
Dec 23, 2025
Merged

Add sets for performers#54
Bukashk0zzz merged 8 commits intoBukashk0zzz:masterfrom
AlexSrc-2:master

Conversation

@AlexSrc-2
Copy link
Contributor

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for sets (collections of related products) to the YML Generator. The implementation follows the existing pattern for categories and currencies, allowing offers to be grouped into sets via set IDs.

Key changes:

  • Introduces a new Set model class with id, name, and url properties
  • Adds set ID fields to offers (both singular setId and plural setsId)
  • Implements set generation in the XML output with conditional rendering based on whether sets are provided

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File Description
src/Model/Set.php New model class representing a set with id, name, and url properties
src/Model/Offer/AbstractOffer.php Adds setId and setsId properties with getters/setters, and integrates set IDs into the XML header options
src/Generator.php Imports Set class, updates generate() signature to accept sets parameter, and adds methods to render sets in XML output
README.md Adds example code demonstrating how to create and use sets

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Bukashk0zzz
Copy link
Owner

Copy link
Owner

@Bukashk0zzz Bukashk0zzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bukashk0zzz
Copy link
Owner

@AlexSrc-2
Copy link
Contributor Author

@Bukashk0zzz Sorry, I was in a hurry... I corrected the code style.

@Bukashk0zzz
Copy link
Owner

@Bukashk0zzz Bukashk0zzz merged commit 130fd0d into Bukashk0zzz:master Dec 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants