-
Notifications
You must be signed in to change notification settings - Fork 4
Improve the plugin for 0.2.0 Release #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ee016fb to
08ceb78
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Qodana for JVM222 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
DonatiFilippo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code was reviewed and most functionality were tested in game.
Approved for merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
House gen is currently broken on 1.21.4
https://pastebin.com/kb0ZQV8C
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add Link to Bstats
| version: "1.0" | ||
| linter: jetbrains/qodana-jvm-community:2025.2 | ||
| profile: | ||
| name: qodana.recommended |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about that acutally, needs to be verified that it's the right profile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If possible add Qodana Badges
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should make the download more visible e.g. a Big Green Download Button (maybe for both dev + releases or too confusing?)
This PR contains major changes to the plugin, making it ready for the next release.
We also switched to Gradle now, which allows us to do more things in the future & improves building performance.
Build's now have a distinct name to tracker better what version is currently running.