Refactor ED25519 curve checker for improved y-coordinate extraction #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd modular arithmetic; update token account hash function for strict binary encoding.
AmarildoGrembi
requested changes
Dec 19, 2025
Member
AmarildoGrembi
left a comment
AmarildoGrembi
left a comment
There was a problem hiding this comment.
Hey @cienhub, sorry for the delay, and good job! I see only 2 issues that I would like you to improve if possible.
…ordinate calculations and ensuring correct field operations.
Author
|
Hey @AmarildoGrembi! Thanks for taking the time to review it. Let me know what do you think |
AmarildoGrembi
approved these changes
Jan 16, 2026
Member
AmarildoGrembi
left a comment
AmarildoGrembi
left a comment
There was a problem hiding this comment.
LGTM! Thanks and apologies for the delay!
Author
|
Thank you too for taking the time! |
Member
Could you please reach out to discord("Amarildo") or telegram ("AmarildoGr") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! This PR should be a fix for #13.
The bugs that I found are described inside the issue.
Please review these changes and let me know wdyt
We faced a specific problem with ATA derivation and these changes fixed the problem for us, so I'm pretty confident about them but I am more than willing to have your opinion on this @AmarildoGrembi