Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@LoneWolfHT (i think you asked about this on discord)
Async mapgen won't work with the
mapsyncmod because of the missingcore.get_metafunction. Mapsync deserializes map metadata (inventories, timers, etc) in the main mapgen thread.Separating map-deserializing and metadata-deserializing in separate environments (sync/async) sounds like asking for trouble (race-conditions, mainly) IMO
Docs: https://github.com/luanti-org/luanti/blob/master/doc/lua_api.md#async-environment
Well, i tried, sounded too good to be true anyway :/