Omit excluded packages in target installed.json#250
Omit excluded packages in target installed.json#250BrianHenryIE wants to merge 11 commits intomasterfrom
installed.json#250Conversation
Summary of ChangesHello @BrianHenryIE, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to omit excluded packages from the target installed.json. The implementation correctly removes the packages from the target installed.json, and a new integration test verifies this behavior. However, the change introduces a potential issue where excluded packages would also be removed from the source vendor/composer/installed.json when package deletion is enabled, which is incorrect. I've suggested a fix to ensure packages are only removed from the target installed.json. Additionally, I've suggested renaming the new test method for clarity.
| if (in_array($package['name'], $this->config->getExcludePackagesFromCopy(), true)) { | ||
| unset($installedJsonArray['packages'][$key]); | ||
| continue; | ||
| } |
There was a problem hiding this comment.
This change correctly removes excluded packages, but it will do so for both the target installed.json and the source vendor/composer/installed.json (when delete_vendor_packages is enabled). Excluded packages should remain in the source vendor/composer/installed.json because they are not being moved or prefixed.
The removal should only happen when processing the installed.json for the target directory. You can achieve this by checking if the $path argument matches the target directory.
if ($path === $this->config->getTargetDirectory() && in_array($package['name'], $this->config->getExcludePackagesFromCopy(), true)) {
unset($installedJsonArray['packages'][$key]);
continue;
}| class StraussIssue249Test extends IntegrationTestCase | ||
| { | ||
|
|
||
| public function test_return_type_double_prefixed(): void |
There was a problem hiding this comment.
The test method name test_return_type_double_prefixed does not seem to reflect what this test is verifying. The test checks that excluded packages are omitted from the target installed.json. A more descriptive name would improve maintainability. For example: test_excluded_packages_are_omitted_from_target_installed_json.
public function test_excluded_packages_are_omitted_from_target_installed_json(): void
|
Code CoverageGenerated: Fri, Feb 20, 2026, 7:24:50 UTC.
|
1 participant
Fix #249