update android-prefix validation to only check for bnc.lt #704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch-deep-linking-attribution
Update min iOS deployment target to satisfy cordova-plugin-firebasex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android Prefix is used to whitelist paths for Android deeplinking.
Limiting it to 3-4 alphanumeric characters is purely for
bnc.itas mentioned in the docs.There should be no reason to force such limitations if
bnc.ltisn't used.This would allow us to only whitelist paths such as
/conf/call/for Android, as it is only possible to do so via AndroidManifest.xml