Skip to content

Conversation

@BradyAJohnston
Copy link
Owner

Improved the de-duplication method. It is now more correct and also faster.

Fixes #4

Code mostly from @Quackarooni

Some relevant synthetic benchmarks below for speed improvements.

benchmark

@BradyAJohnston BradyAJohnston changed the title improved deduplication method Improved Deduplication Method Nov 5, 2025
@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.85%. Comparing base (313665d) to head (7435077).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
databpy/nodes/appending.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
+ Coverage   89.76%   89.85%   +0.08%     
==========================================
  Files          13       13              
  Lines         782      779       -3     
==========================================
- Hits          702      700       -2     
+ Misses         80       79       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BradyAJohnston BradyAJohnston merged commit 4b39b08 into main Nov 5, 2025
24 checks passed
@BradyAJohnston BradyAJohnston deleted the deduplication branch November 5, 2025 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cleanup deduplication

2 participants