Copy gl-sdk library from cargo target to python's expected location#645
Merged
ShahanaFarooqui merged 1 commit intoBlockstream:mainfrom Dec 4, 2025
Merged
Conversation
The gl-sdk Python package build was failing because while cargo build --workspace successfully compiles libglsdk.so into the Cargo target directory (target/release/libglsdk.so), the Python package's pyproject.toml expects this shared library at libs/gl-sdk/glsdk/libglsdk.so as a forced inclusion, causing uv sync to fail with a FileNotFoundError when attempting to build the editable wheel. This fix adds a step to copy the compiled library from the Cargo build output to the expected Python package location before running uv sync, ensuring the file exists when hatchling processes the forced inclusion.
cdecker
approved these changes
Dec 4, 2025
Collaborator
Author
|
Test run also passed 19937849633. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
gl-sdkPython package build was failing because whilecargo build --workspacesuccessfully compileslibglsdk.sointo the Cargo target directory (target/release/libglsdk.so), the Python package's pyproject.toml expects this shared library atlibs/gl-sdk/glsdk/libglsdk.soas a forced inclusion, causing uv sync to fail with aFileNotFoundErrorwhen attempting to build the editable wheel.This fix adds a step to copy the compiled library from the Cargo build output to the expected Python package location before running
uv sync, ensuring the file exists.