glclient: lift default decoding size#599
Merged
cdecker merged 1 commit intoBlockstream:mainfrom May 8, 2025
Merged
Conversation
Lift the maximum decoding message size from 4MB to 32MB by default. Prevent large gRPC responses from failing. Make it configurable via the Node builder. Retain a safe default to limit DoS risks We trust the server logic, so increasing the default is safe.
cdecker
approved these changes
May 8, 2025
Collaborator
|
Very nice, thank you @YusukeShimizu 🤗 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#597
Lift the maximum decoding message size from 4MB to 32MB by default.
Prevent large gRPC responses from failing.
Make it configurable via the Node builder.
We trust the server logic, so increasing the default is safe.