Merged
Conversation
kescobo
reviewed
Jan 29, 2026
Member
kescobo
left a comment
There was a problem hiding this comment.
I'm getting real "get a TUI to 60fps" vibes here...
https://youtu.be/LvW1HTSLPEk?si=dUJWFk3UB-hwkCvN
(This is not a criticism of you)
Member
|
Hey, it works! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clicking links from https://biojulia.dev/dev/ to other sites hosted on the same domain (e.g. https://biojulia.dev/BioTutorials/dev/, https://biojulia.dev/TwoBit.jl/stable/) shows a 404 page until a refresh. This happens because the VitePress client router navigates to these links within the https://biojulia.dev/dev. However, these links don't have the
/devat the end of their URL (this is just added to the biojulia website during deployment)This PR updates the external “feature card” links on the homepage (
docs/src/index.md) to usetarget="_blank"andrel="noopener noreferrer", bypassing the VitePress router and ensuring the browser performs a real navigation. This makes sure that a new webpage is opened, rather than just navigating withinhttps://biojulia.dev/dev/.rel="noopener noreferrer"also prevents window.opener access for security. This prevents a user from clicking back. This isn't inherently related to the problem, but this is a common pattern that people use.The old solution that was merged in (
rel="external") didn't work. While this tells VitePress that the website is an external website, this is a piece of metadata. It doesn't tell Vitepress to change how it handles opening the link.