Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19 +/- ##
==========================================
+ Coverage 97.89% 98.20% +0.31%
==========================================
Files 10 9 -1
Lines 333 335 +2
==========================================
+ Hits 326 329 +3
+ Misses 7 6 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 tasks
jakobnissen
force-pushed
the
no_unsafe
branch
from
46c3652 to
1d3aa0d
Compare
As pointed out by others, this means the method table for public objects contain a mix of public and private methods. That's bad. Instead, use things with private names to do our dirty unsafe business. This is an API change, so I'll leave it for a bit before merging, in case other breaking stuff comes up.
jakobnissen
force-pushed
the
no_unsafe
branch
from
310a767 to
5f6298a
Compare
jakobnissen
force-pushed
the
no_unsafe
branch
from
5f6298a to
df206ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As pointed out by others, this means the method table for public objects contain a mix of public and private methods. That's bad. Instead, use things with private names to do our dirty unsafe business.
This is an API change, so I'll leave it for a bit before merging, in case other breaking stuff comes up.